JAkutenshi opened a new pull request, #5384: URL: https://github.com/apache/ignite-3/pull/5384
JIRA Ticket: [IGNITE-24749](https://issues.apache.org/jira/browse/IGNITE-24749) ## The goal The main goal is to remove duplicated usage of properties `INTERVAL_SYSTEM_PROPERTY_NAME` and `DATA_AVAILABILITY_TIME_SYSTEM_PROPERTY_NAME` and add a tests that check names weren't changed for all found system configuration * `REBALANCE_RETRY_DELAY_DEFAULT` * `PARTITION_DISTRIBUTION_RESET_TIMEOUT_DEFAULT_VALUE` * `INTERVAL_SYSTEM_PROPERTY_NAME` * `DATA_AVAILABILITY_TIME_SYSTEM_PROPERTY_NAME` * `LOCK_MAP_SIZE_PROPERTY_NAME` ## The reason We shouldn't duplicate code without a reason, compatibility may be checked through tests. ## The solution The duplication part is trivial. Tests was implemented with a separate static method in `ignite-configuration-system` fixture that comparing actual and expected values of a given property and fails with the same message if the property name was changed by a developer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
