sashapolo commented on code in PR #5367:
URL: https://github.com/apache/ignite-3/pull/5367#discussion_r1987155055
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -974,28 +959,27 @@ private CompletableFuture<Boolean>
onPrimaryReplicaExpired(PrimaryReplicaEventPa
return falseCompletedFuture();
}
- private void processAssignmentsOnRecovery(long recoveryRevision) {
- var stableAssignmentsPrefix = new
ByteArray(STABLE_ASSIGNMENTS_PREFIX_BYTES);
- var pendingAssignmentsPrefix = new
ByteArray(PENDING_ASSIGNMENTS_QUEUE_PREFIX_BYTES);
+ private CompletableFuture<Void> processAssignmentsOnRecovery(long
recoveryRevision) {
Review Comment:
This is actually an interesting comment, because I did this refactoring only
because calling `handleAssignmentsOnRecovery` inside `thenCompose` looked very
ugly. But looking at the `PartitionReplicaLifecycleManager`, we don't need to
recover assignments sequentially, it can be done in parallel, so this
refactoring is not needed. So what I am going to do instead is I'll change this
code to look like the on in `PartitionReplicaLifecycleManager`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
