IgGusev commented on code in PR #5315: URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1983272572
########## docs/_docs/administrators-guide/lifecycle.adoc: ########## @@ -40,7 +40,15 @@ First, the nodes specified in the `--cluster-management-group` argument form a R image::images/lifecycle1.png[Cluster initialization] -Then, the nodes specified in the `--metastorage-group` argument form a RAFT group and take the role of *metastorage group*. These nodes will hold the authoritative copy of cluster meta information. +Then, the nodes specified in the `--metastorage-group` argument form a RAFT group and take the role of *metastorage group*. These nodes will hold the authoritative copy of cluster meta information. If `--metastorage-group` is not specified, the nodes are chosen automatically. The number of nodes is chosen automatically as follows: + +[source, javascript] Review Comment: This is not a code sample, it should be normal text, probably a list. ########## docs/_docs/administrators-guide/lifecycle.adoc: ########## @@ -40,7 +40,15 @@ First, the nodes specified in the `--cluster-management-group` argument form a R image::images/lifecycle1.png[Cluster initialization] -Then, the nodes specified in the `--metastorage-group` argument form a RAFT group and take the role of *metastorage group*. These nodes will hold the authoritative copy of cluster meta information. +Then, the nodes specified in the `--metastorage-group` argument form a RAFT group and take the role of *metastorage group*. These nodes will hold the authoritative copy of cluster meta information. If `--metastorage-group` is not specified, the nodes are chosen automatically. The number of nodes is chosen automatically as follows: Review Comment: We should also specify which nodes are chosen, that we chose by name in alphabetical order. ########## docs/_docs/administrators-guide/lifecycle.adoc: ########## @@ -40,7 +40,15 @@ First, the nodes specified in the `--cluster-management-group` argument form a R image::images/lifecycle1.png[Cluster initialization] -Then, the nodes specified in the `--metastorage-group` argument form a RAFT group and take the role of *metastorage group*. These nodes will hold the authoritative copy of cluster meta information. +Then, the nodes specified in the `--metastorage-group` argument form a RAFT group and take the role of *metastorage group*. These nodes will hold the authoritative copy of cluster meta information. If `--metastorage-group` is not specified, the nodes are chosen automatically. The number of nodes is chosen automatically as follows: + +[source, javascript] +---- +metastorage_group_size = + cluster_size <= 3 ? cluster_size // If up to 3 nodes, use all nodes for CMG and metastorage. + : cluster_size == 4 ? 3 // If 4 nodes, use 3 nodes to have an odd number of nodes for better split-brain protection. + : 5 // Use 5 nodes on larger clusters; don't use more to avoid unnecessary overhead. Review Comment: This should also include info that if cmg is specified, we have the same size as it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
