slukyano commented on code in PR #5315:
URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984172209
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterInitializer.java:
##########
@@ -107,29 +107,44 @@ public CompletableFuture<Void> initCluster(
String clusterName,
@Nullable String clusterConfiguration
) {
- if (metaStorageNodeNames.isEmpty()) {
- throw new IllegalArgumentException("Meta Storage node names list
must not be empty");
- }
-
if (metaStorageNodeNames.stream().anyMatch(StringUtils::nullOrBlank)) {
throw new IllegalArgumentException("Meta Storage node names must
not contain blank strings: " + metaStorageNodeNames);
}
- if (!cmgNodeNames.isEmpty() &&
cmgNodeNames.stream().anyMatch(StringUtils::nullOrBlank)) {
+ Set<String> msNodeNameSet =
metaStorageNodeNames.stream().map(String::trim).collect(toUnmodifiableSet());
+ if (msNodeNameSet.size() != metaStorageNodeNames.size()) {
+ throw new IllegalArgumentException("Meta Storage node names must
not contain duplicates: " + metaStorageNodeNames);
+ }
+
+ if (cmgNodeNames.stream().anyMatch(StringUtils::nullOrBlank)) {
throw new IllegalArgumentException("CMG node names must not
contain blank strings: " + cmgNodeNames);
}
+ Set<String> cmgNodeNameSet =
cmgNodeNames.stream().map(String::trim).collect(toUnmodifiableSet());
+ if (cmgNodeNameSet.size() != cmgNodeNames.size()) {
+ throw new IllegalArgumentException("CMG node names must not
contain duplicates: " + metaStorageNodeNames);
+ }
+
+
+ if (msNodeNameSet.isEmpty() && cmgNodeNameSet.isEmpty()) {
+ var clusterNodes = clusterService.topologyService().allMembers();
+ var topologySize = clusterNodes.size();
+ var numberOfMsNodes = topologySize < 5 ? 3 : 5;
+ var chosenNodes =
clusterNodes.stream().map(ClusterNode::name).sorted().limit(numberOfMsNodes)
Review Comment:
It is expected that the user runs the `init` on a stable topology, so the
topology view should be the same on all nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
