slukyano commented on code in PR #5315:
URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984176610
##########
modules/runner/src/main/java/org/apache/ignite/InitParametersBuilder.java:
##########
@@ -71,11 +70,9 @@ public InitParametersBuilder
metaStorageNodeNames(Collection<String> metaStorage
* @return {@code this} for chaining.
*/
public InitParametersBuilder metaStorageNodes(IgniteServer...
metaStorageNodes) {
- if (metaStorageNodes == null) {
- throw new IllegalArgumentException("Meta storage nodes cannot be
null.");
- }
- if (metaStorageNodes.length == 0) {
- throw new IllegalArgumentException("Meta storage nodes cannot be
empty.");
+ if (metaStorageNodes == null || metaStorageNodes.length == 0) {
Review Comment:
I don't understand the question. You accept a parameter - you check boundary
conditions - you default them to whatever the downstream API needs. Especially
here, in a public API, we need to handle all possible inputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
