Re: [PR] IGNITE-24244 Support timeout in RW transactions [ignite-3]

[via GitHub]

PakhomovAlexander commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1983161899


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -1730,16 +1761,21 @@ protected CompletableFuture<Void> onClose(boolean 
intentionallyClose, long scanI
 
                     PendingTxPartitionEnlistment enlistment = 
tx.enlistedPartition(replicationGrpId);
                     opFut = enlistment != null ? completeScan(
-                        tx.id(),
-                        replicationGrpId,
-                        scanId,
-                        th,
-                        enlistment.primaryNodeConsistentId(),
-                        intentionallyClose
+                            tx.id(),

Review Comment:
   Let's look at existing code around. Here is line 375. The number of spaces 
is 8. 
   
   ![Image 06 03 2025 at 14 
04](https://github.com/user-attachments/assets/a1036e7b-8705-4e8b-a70c-4c9c940255ca)
   



##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -1730,16 +1761,21 @@ protected CompletableFuture<Void> onClose(boolean 
intentionallyClose, long scanI
 
                     PendingTxPartitionEnlistment enlistment = 
tx.enlistedPartition(replicationGrpId);
                     opFut = enlistment != null ? completeScan(
-                        tx.id(),
-                        replicationGrpId,
-                        scanId,
-                        th,
-                        enlistment.primaryNodeConsistentId(),
-                        intentionallyClose
+                            tx.id(),

Review Comment:
   Let's look at existing code around. Here is line 375. The number of spaces 
is 8. 
   
   ![Image 06 03 2025 at 14 
04](https://github.com/user-attachments/assets/a1036e7b-8705-4e8b-a70c-4c9c940255ca)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org