PakhomovAlexander commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1983222588
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##########
@@ -1040,20 +1048,24 @@ private Row createKeyRow(int id) {
private InternalTransaction startTxWithEnlistedPartition(int partId,
boolean readOnly) {
IgniteImpl ignite = unwrapIgniteImpl(CLUSTER.aliveNode());
- InternalTransaction tx = (InternalTransaction)
ignite.transactions().begin(new TransactionOptions().readOnly(readOnly));
+ InternalTransaction tx = (InternalTransaction)
ignite.transactions().begin(
+ new
TransactionOptions().timeoutMillis(10_000).readOnly(readOnly)
Review Comment:
Actually, you asked a good question. I rewrote the comment.
```java
InternalTransaction tx = (InternalTransaction)
ignite.transactions().begin(
// Default values for timeout is too long for the test,
// So the test changes them to 5 secs. As a result,
// implicit RW transactions have 5 secs timeout.
// But we want explicit transaction to be longer that
implicit one,
// so here we set timeout to 10 seconds.
new
TransactionOptions().timeoutMillis(10_000).readOnly(readOnly)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
