rpuch commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1982788797
##########
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransactions.java:
##########
@@ -33,6 +33,8 @@
* Client transactions implementation.
*/
public class ClientTransactions implements IgniteTransactions {
+ private static final int DEFAULT_TIMEOUT = 0;
Review Comment:
The added constant kinda tells us that the default timeout is 0. But
actually, the intention is to tell the server that it should take ITS default
from the configuration, so current declaration looks confusing. Maybe renaming
it to `USE_CONFIGURED_TIMEOUT_DEFAULT` would be better than `DEFAULT_TIMEOUT`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
