PakhomovAlexander commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1981500455
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -1730,16 +1761,21 @@ protected CompletableFuture<Void> onClose(boolean
intentionallyClose, long scanI
PendingTxPartitionEnlistment enlistment =
tx.enlistedPartition(replicationGrpId);
opFut = enlistment != null ? completeScan(
- tx.id(),
- replicationGrpId,
- scanId,
- th,
- enlistment.primaryNodeConsistentId(),
- intentionallyClose
+ tx.id(),
Review Comment:
Ops, our formatter allow this. Meaning that it is not broken at all. Do I
miss something?
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -1730,16 +1761,21 @@ protected CompletableFuture<Void> onClose(boolean
intentionallyClose, long scanI
PendingTxPartitionEnlistment enlistment =
tx.enlistedPartition(replicationGrpId);
opFut = enlistment != null ? completeScan(
- tx.id(),
- replicationGrpId,
- scanId,
- th,
- enlistment.primaryNodeConsistentId(),
- intentionallyClose
+ tx.id(),
Review Comment:
Ops, our formatter allows this. Meaning that it is not broken at all. Do I
miss something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
