JAkutenshi commented on code in PR #5258:
URL: https://github.com/apache/ignite-3/pull/5258#discussion_r1981728618
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java:
##########
@@ -268,13 +272,24 @@ private IgniteBiTuple<Serializable, Boolean>
processCrossTableProcessorsCommand(
) {
IgniteBiTuple<Serializable, Boolean> result = new
IgniteBiTuple<>(null, false);
- tableProcessors.values().forEach(processor -> {
- IgniteBiTuple<Serializable, Boolean> r =
processor.processCommand(command, commandIndex, commandTerm, safeTimestamp);
- // Need to adjust the safe time if any of the table processors
successfully handled the command.
- if (Boolean.TRUE.equals(r.get2())) {
- result.set2(Boolean.TRUE);
+ if (tableProcessors.isEmpty()) {
+ synchronized (tableProcessorsStateLock) {
+ if (lastAppliedIndex < commandIndex) {
+ lastAppliedIndex = commandIndex;
Review Comment:
Fair, changed
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java:
##########
@@ -268,13 +272,24 @@ private IgniteBiTuple<Serializable, Boolean>
processCrossTableProcessorsCommand(
) {
IgniteBiTuple<Serializable, Boolean> result = new
IgniteBiTuple<>(null, false);
- tableProcessors.values().forEach(processor -> {
- IgniteBiTuple<Serializable, Boolean> r =
processor.processCommand(command, commandIndex, commandTerm, safeTimestamp);
- // Need to adjust the safe time if any of the table processors
successfully handled the command.
- if (Boolean.TRUE.equals(r.get2())) {
- result.set2(Boolean.TRUE);
+ if (tableProcessors.isEmpty()) {
+ synchronized (tableProcessorsStateLock) {
+ if (lastAppliedIndex < commandIndex) {
+ lastAppliedIndex = commandIndex;
+ lastAppliedTerm = commandTerm;
+
+ result.set2(Boolean.TRUE);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
