JAkutenshi commented on code in PR #5258:
URL: https://github.com/apache/ignite-3/pull/5258#discussion_r1981366270
##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItReplicaLifecycleTest.java:
##########
@@ -636,6 +639,54 @@ public void testScanCloseReplicaRequest() throws Exception
{
assertDoesNotThrow(tx::commit);
}
+ @Test
+ public void testReplicaSafeTimeSyncRequest() throws Exception {
+ startCluster(2);
+ Node node = getNode(0);
+
+ // Prepare a zone.
+ String zoneName = "test_zone";
+ createZone(node, zoneName, 1, 2);
+ int zoneId = DistributionZonesTestUtil.getZoneId(node.catalogManager,
zoneName, node.hybridClock.nowLong());
+ int partId = 0;
+
+ // Wait for sure that zone replication group was created on both nodes.
+ waitForZoneReplicaStartedOnNode(node, zoneId, partId);
+ waitForZoneReplicaStartedOnNode(getNode(1), zoneId, partId);
Review Comment:
Not sure, but used method looks more verbose and precise for the situation,
isn't?
##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItReplicaLifecycleTest.java:
##########
@@ -636,6 +639,54 @@ public void testScanCloseReplicaRequest() throws Exception
{
assertDoesNotThrow(tx::commit);
}
+ @Test
+ public void testReplicaSafeTimeSyncRequest() throws Exception {
+ startCluster(2);
+ Node node = getNode(0);
+
+ // Prepare a zone.
+ String zoneName = "test_zone";
+ createZone(node, zoneName, 1, 2);
+ int zoneId = DistributionZonesTestUtil.getZoneId(node.catalogManager,
zoneName, node.hybridClock.nowLong());
+ int partId = 0;
+
+ // Wait for sure that zone replication group was created on both nodes.
+ waitForZoneReplicaStartedOnNode(node, zoneId, partId);
+ waitForZoneReplicaStartedOnNode(getNode(1), zoneId, partId);
+
+ // Check that time was adjusted even without table.
+ checkSafeTimeWasAdjustedForZoneGroup(zoneId, partId);
+
+ // Create a table to work with.
+ String tableName = "test_table";
+ createTable(node, zoneName, tableName);
+ assertDoesNotThrow(() ->
TableTestUtils.getTableIdStrict(node.catalogManager, tableName,
node.hybridClock.nowLong()));
+
+ // Check that time was adjusted table.
+ checkSafeTimeWasAdjustedForZoneGroup(zoneId, partId);
+ }
+
+ private static void waitForZoneReplicaStartedOnNode(Node node, int zoneId,
int partId) throws InterruptedException {
+ ZonePartitionId zoneReplicationId = new ZonePartitionId(zoneId,
partId);
+
+ waitForCondition(() -> node.replicaManager.replica(zoneReplicationId)
!= null, AWAIT_TIMEOUT_MILLIS);
Review Comment:
Fixed, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
