alievmirza commented on code in PR #5158:
URL: https://github.com/apache/ignite-3/pull/5158#discussion_r1979264158
##########
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java:
##########
@@ -2710,28 +2717,33 @@ public void
testAppendEntriesWhenFollowerIsInErrorState() throws Exception {
}
@Test
- @Disabled("https://issues.apache.org/jira/browse/IGNITE-21792";)
+ @Timeout(value = 25, unit = TimeUnit.SECONDS)
public void testFollowerStartStopFollowing() throws Exception {
// start five nodes
List<TestPeer> peers = TestUtils.generatePeers(testInfo, 5);
- cluster = new TestCluster("unitest", dataPath, peers,
ELECTION_TIMEOUT_MILLIS, testInfo);
+ cluster = new TestCluster("unittest", dataPath, peers,
ELECTION_TIMEOUT_MILLIS, testInfo);
for (TestPeer peer : peers)
assertTrue(cluster.start(peer));
Node firstLeader = cluster.waitAndGetLeader();
assertNotNull(firstLeader);
cluster.ensureLeader(firstLeader);
+ //we don't want any timeouts after the first leader election for this
test
+ for (Node nodes : cluster.getNodes()) {
+ nodes.resetElectionTimeoutMs(100_000);
Review Comment:
Unfortunately, this do not prevent election, as you've expected.
As you can see in the test scenario further, we stop current leader
```
// stop leader and elect new one
PeerId fstLeaderAddr = firstLeader.getNodeId().getPeerId();
assertTrue(cluster.stop(fstLeaderAddr));
```
And new leader is elected in a short time. This is because of the
`TimeoutNowRequest` optimisation, which starts voting immediately.
To sum up, I don't think that this idea to reset timeout to some big value
could bring us any profit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
