12rcu commented on PR #5158: URL: https://github.com/apache/ignite-3/pull/5158#issuecomment-2659010889
> Please remove it, this is run in a test environment, we shouldn't expect high load there. > > Overall, your changes look reasonable to me. But if the issue was in the election timeout, shouldn't your PR fix the test flakiness? Did you try running it many times? Replaced the retry annotation with the `@Test` annotation. I wouldn't go so far as to say that it completely fixes the flakiness. You said that you don't expect high load in test environments, in my experience it can still happen that a test in a container can take longer than expected and therefore still run into timeout issues. But I don't think this is a problem because other tests use the same timeout mechanism and work fine. In my test runs, I only ran into timeout problems when my system load was high. But then I also got failures of other tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
