AMashenkov commented on code in PR #5293: URL: https://github.com/apache/ignite-3/pull/5293#discussion_r1977899623
########## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/serialization/CatalogEntrySerializerProviderImpl.java: ########## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.catalog.storage.serialization; + +import it.unimi.dsi.fastutil.ints.Int2ObjectMap; +import it.unimi.dsi.fastutil.ints.Int2ObjectMaps; +import it.unimi.dsi.fastutil.ints.Int2ObjectOpenHashMap; +import java.lang.reflect.Constructor; +import java.lang.reflect.InvocationTargetException; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import org.apache.ignite.internal.lang.IgniteStringFormatter; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.logger.Loggers; + +/** + * Default serializer provider implementation. + */ +class CatalogEntrySerializerProviderImpl implements CatalogEntrySerializerProvider { + private final Int2ObjectMap<CatalogVersionAwareSerializer<? extends MarshallableEntry>[]> serializers; + + CatalogEntrySerializerProviderImpl(List<CatalogSerializerTypeDefinition> serializerTypes) { + SerializerRegistryBuilder registryBuilder = new SerializerRegistryBuilder(serializerTypes, this); + + try { + serializers = registryBuilder.build(); + } catch (Throwable t) { + IgniteLogger logger = Loggers.forClass(CatalogEntrySerializerProviderImpl.class); + + logger.error("Failed to build serializer registry.", t); + + throw t; + } + } + + @Override + public <T extends MarshallableEntry> CatalogVersionAwareSerializer<T> get(int version, int typeId) { + CatalogVersionAwareSerializer<? extends MarshallableEntry>[] serializersArray = serializerOrThrow(typeId); + + if (version <= 0) { + throw new IllegalArgumentException("Serializer version must be positive [version=" + version + "]."); + } + + if (version > serializersArray.length) { + throw new IllegalArgumentException("Required serializer version not found [version=" + version + "]."); + } + + return (CatalogVersionAwareSerializer<T>) serializersArray[version - 1]; + } + + @Override + public int latestSerializerVersion(int typeId) { + return serializerOrThrow(typeId).length; Review Comment: The current implementation is error prone, it relies on fact the version is monotonic increasing number starting from 1. Any violation will may break compatibility. If this invariant must always have a place, then there should be a validation in the code that proves provider data is consistent. Let's better build `Int2IntMap` for `entry_type -> latest_version` pairs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
