AMashenkov commented on code in PR #5293: URL: https://github.com/apache/ignite-3/pull/5293#discussion_r1977725185
########## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogSortedIndexDescriptorSerializers.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.catalog.descriptors; + +import static org.apache.ignite.internal.catalog.storage.serialization.CatalogSerializationUtils.readList; +import static org.apache.ignite.internal.catalog.storage.serialization.CatalogSerializationUtils.writeList; + +import java.io.IOException; +import java.util.List; +import org.apache.ignite.internal.catalog.storage.serialization.CatalogEntrySerializerProvider; +import org.apache.ignite.internal.catalog.storage.serialization.CatalogObjectSerializer; +import org.apache.ignite.internal.catalog.storage.serialization.CatalogSerializer; +import org.apache.ignite.internal.catalog.storage.serialization.MarshallableEntryType; +import org.apache.ignite.internal.util.io.IgniteDataInput; +import org.apache.ignite.internal.util.io.IgniteDataOutput; + +/** + * Serializers for {@link CatalogSortedIndexDescriptor}. + */ +public class CatalogSortedIndexDescriptorSerializers { Review Comment: `CatalogIndexColumnDescriptor` class can be an inner class of SortedIndexDescriptor be its semantics. I think, it barely makes sense to have a dedicated serializer for the column descriptor. For example,`SortedIndexDescriptor`- serializer may have better storing format: * ordered list of column names * list of column collations is same order, which can be compressed. Column collation is defined as pair of value order and null order, both are one of "asc" or "desc". So, collation can be represented by 2 bits and written compactly like a bitset and we can save much more bytes if avoid writing same type/version for every column. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
