AMashenkov commented on code in PR #5311:
URL: https://github.com/apache/ignite-3/pull/5311#discussion_r1977466718
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/IgniteMdSelectivity.java:
##########
@@ -108,7 +110,7 @@ private static double computeOpsSelectivity(Map<RexNode,
List<SqlKind>> operands
* OR(<($t3, 110), >($t3, 150), AND(>=($t2, -($t1, 2)), <=($t2, +($t3,
2))), >($t4, $t2), <($t4, $t3)) selectivity computes separately
* for each local ref with AND selectivity adjustment. <br>
*/
- private static double computeOrSelectivity(RexCall call, @Nullable BitSet
primaryKeys) {
+ private static double computeOrSelectivity(RexCall call, @Nullable BitSet
primaryKeys, @Nullable Mapping columnMapping) {
Review Comment:
I suggest to move unrelated changed to a separate PR,
because the current ticket may be declined or postponed due to any reason,
and this should NOT affect the valid issue you found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
