ibessonov commented on code in PR #5328:
URL: https://github.com/apache/ignite-3/pull/5328#discussion_r1977033446
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/datastructure/DataStructure.java:
##########
@@ -446,6 +439,6 @@ protected int pageSize() {
*/
@Override
public void close() {
- lockLsnr.close();
+ // No-op.
Review Comment:
No, all implementations will be the same, no-op close looks better. Maybe we
should remove the `close` method entirely, but not in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
