ibessonov commented on code in PR #5328:
URL: https://github.com/apache/ignite-3/pull/5328#discussion_r1977035499
##########
modules/page-memory/src/testFixtures/java/org/apache/ignite/internal/pagememory/util/PageLockListener.java:
##########
@@ -27,60 +27,46 @@ public interface PageLockListener extends ManuallyCloseable
{
/**
* Callback that's called before write lock acquiring.
*
- * @param groupId Group ID.
- * @param pageId Page ID.
- * @param page Page pointer.
+ * @param lock Lock pointer.
*/
- void onBeforeWriteLock(int groupId, long pageId, long page);
+ void onBeforeWriteLock(long lock);
Review Comment:
We usually call them "children". Here I will do a rename, because it's a
"new" class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
