rpuch commented on code in PR #5276: URL: https://github.com/apache/ignite-3/pull/5276#discussion_r1975165287
########## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItBuildIndexTest.java: ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.partition.replicator; + +import static org.apache.ignite.internal.catalog.descriptors.CatalogIndexStatus.AVAILABLE; +import static org.apache.ignite.internal.placementdriver.event.PrimaryReplicaEvent.PRIMARY_REPLICA_ELECTED; +import static org.apache.ignite.internal.sql.SqlCommon.DEFAULT_SCHEMA_NAME; +import static org.apache.ignite.internal.testframework.IgniteTestUtils.waitForCondition; +import static org.apache.ignite.sql.ColumnType.DOUBLE; +import static org.apache.ignite.sql.ColumnType.INT32; +import static org.apache.ignite.sql.ColumnType.INT64; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.catalog.CatalogManager; +import org.apache.ignite.internal.catalog.commands.ColumnParams; +import org.apache.ignite.internal.catalog.descriptors.CatalogIndexDescriptor; +import org.apache.ignite.internal.hlc.HybridClock; +import org.apache.ignite.internal.index.message.IndexMessageGroup; +import org.apache.ignite.internal.index.message.IndexMessagesFactory; +import org.apache.ignite.internal.index.message.IsNodeFinishedRwTransactionsStartedBeforeRequest; +import org.apache.ignite.internal.partition.replicator.fixtures.Node; +import org.apache.ignite.internal.placementdriver.event.PrimaryReplicaEventParameters; +import org.apache.ignite.internal.replicator.TablePartitionId; +import org.apache.ignite.internal.table.TableTestUtils; +import org.apache.ignite.internal.table.TableViewInternal; +import org.apache.ignite.table.KeyValueView; +import org.apache.ignite.table.Tuple; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.Timeout; + +// TODO: https://issues.apache.org/jira/browse/IGNITE-22522 remove this test after the switching to zone-based replication +/** + * Tests catalog compaction for colocation track. Review Comment: The javadoc says one thing, but the class name says something different ########## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItBuildIndexTest.java: ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.partition.replicator; + +import static org.apache.ignite.internal.catalog.descriptors.CatalogIndexStatus.AVAILABLE; +import static org.apache.ignite.internal.placementdriver.event.PrimaryReplicaEvent.PRIMARY_REPLICA_ELECTED; +import static org.apache.ignite.internal.sql.SqlCommon.DEFAULT_SCHEMA_NAME; +import static org.apache.ignite.internal.testframework.IgniteTestUtils.waitForCondition; +import static org.apache.ignite.sql.ColumnType.DOUBLE; +import static org.apache.ignite.sql.ColumnType.INT32; +import static org.apache.ignite.sql.ColumnType.INT64; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.catalog.CatalogManager; +import org.apache.ignite.internal.catalog.commands.ColumnParams; +import org.apache.ignite.internal.catalog.descriptors.CatalogIndexDescriptor; +import org.apache.ignite.internal.hlc.HybridClock; +import org.apache.ignite.internal.index.message.IndexMessageGroup; +import org.apache.ignite.internal.index.message.IndexMessagesFactory; +import org.apache.ignite.internal.index.message.IsNodeFinishedRwTransactionsStartedBeforeRequest; +import org.apache.ignite.internal.partition.replicator.fixtures.Node; +import org.apache.ignite.internal.placementdriver.event.PrimaryReplicaEventParameters; +import org.apache.ignite.internal.replicator.TablePartitionId; +import org.apache.ignite.internal.table.TableTestUtils; +import org.apache.ignite.internal.table.TableViewInternal; +import org.apache.ignite.table.KeyValueView; +import org.apache.ignite.table.Tuple; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.Timeout; + +// TODO: https://issues.apache.org/jira/browse/IGNITE-22522 remove this test after the switching to zone-based replication +/** + * Tests catalog compaction for colocation track. + */ +@Timeout(60) +public class ItBuildIndexTest extends ItAbstractColocationTest { + private static final IndexMessagesFactory FACTORY = new IndexMessagesFactory(); + + @Test + public void testBuildIndex() throws Exception { + // Prepare a single node cluster. + startCluster(1); + Node node = getNode(0); + + placementDriver.setPrimary(node.clusterService.topologyService().localMember()); + + String zoneName = "test-zone"; + createZone(node, zoneName, 1, 1); + + String tableName = "TEST_TABLE"; + createCustomTable(node, zoneName, tableName); + int tableId = TableTestUtils.getTableId(node.catalogManager, tableName, node.hybridClock.nowLong()); + + // Test node does not create IndexNodeFinishedRwTransactionsChecker, so the following code is needed to unblock index building. + // It's easier than creating a real service with all its dependencies. + node.clusterService.messagingService().addMessageHandler( + IndexMessageGroup.class, + (message, sender, correlationId) -> { + if (message instanceof IsNodeFinishedRwTransactionsStartedBeforeRequest) { + node.clusterService.messagingService().respond( + sender, + FACTORY.isNodeFinishedRwTransactionsStartedBeforeResponse().finished(true).build(), + correlationId + ); + } + }); + + // Firing this event is a workaround to trigger the index building process. + // I agree that this approach is far from a good one and looks like a hack, + // but it's the only way to unblock the index building process using our test node. + placementDriver.fireTestEvent( + PRIMARY_REPLICA_ELECTED, + new PrimaryReplicaEventParameters( + 85, // causalityToken, Review Comment: How was 85 chosen? ########## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItBuildIndexTest.java: ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.partition.replicator; + +import static org.apache.ignite.internal.catalog.descriptors.CatalogIndexStatus.AVAILABLE; +import static org.apache.ignite.internal.placementdriver.event.PrimaryReplicaEvent.PRIMARY_REPLICA_ELECTED; +import static org.apache.ignite.internal.sql.SqlCommon.DEFAULT_SCHEMA_NAME; +import static org.apache.ignite.internal.testframework.IgniteTestUtils.waitForCondition; +import static org.apache.ignite.sql.ColumnType.DOUBLE; +import static org.apache.ignite.sql.ColumnType.INT32; +import static org.apache.ignite.sql.ColumnType.INT64; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.catalog.CatalogManager; +import org.apache.ignite.internal.catalog.commands.ColumnParams; +import org.apache.ignite.internal.catalog.descriptors.CatalogIndexDescriptor; +import org.apache.ignite.internal.hlc.HybridClock; +import org.apache.ignite.internal.index.message.IndexMessageGroup; +import org.apache.ignite.internal.index.message.IndexMessagesFactory; +import org.apache.ignite.internal.index.message.IsNodeFinishedRwTransactionsStartedBeforeRequest; +import org.apache.ignite.internal.partition.replicator.fixtures.Node; +import org.apache.ignite.internal.placementdriver.event.PrimaryReplicaEventParameters; +import org.apache.ignite.internal.replicator.TablePartitionId; +import org.apache.ignite.internal.table.TableTestUtils; +import org.apache.ignite.internal.table.TableViewInternal; +import org.apache.ignite.table.KeyValueView; +import org.apache.ignite.table.Tuple; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.Timeout; + +// TODO: https://issues.apache.org/jira/browse/IGNITE-22522 remove this test after the switching to zone-based replication +/** + * Tests catalog compaction for colocation track. + */ +@Timeout(60) +public class ItBuildIndexTest extends ItAbstractColocationTest { + private static final IndexMessagesFactory FACTORY = new IndexMessagesFactory(); + + @Test + public void testBuildIndex() throws Exception { + // Prepare a single node cluster. + startCluster(1); + Node node = getNode(0); + + placementDriver.setPrimary(node.clusterService.topologyService().localMember()); + + String zoneName = "test-zone"; + createZone(node, zoneName, 1, 1); + + String tableName = "TEST_TABLE"; + createCustomTable(node, zoneName, tableName); + int tableId = TableTestUtils.getTableId(node.catalogManager, tableName, node.hybridClock.nowLong()); + + // Test node does not create IndexNodeFinishedRwTransactionsChecker, so the following code is needed to unblock index building. + // It's easier than creating a real service with all its dependencies. + node.clusterService.messagingService().addMessageHandler( + IndexMessageGroup.class, + (message, sender, correlationId) -> { + if (message instanceof IsNodeFinishedRwTransactionsStartedBeforeRequest) { + node.clusterService.messagingService().respond( + sender, + FACTORY.isNodeFinishedRwTransactionsStartedBeforeResponse().finished(true).build(), + correlationId + ); + } + }); + + // Firing this event is a workaround to trigger the index building process. + // I agree that this approach is far from a good one and looks like a hack, + // but it's the only way to unblock the index building process using our test node. + placementDriver.fireTestEvent( + PRIMARY_REPLICA_ELECTED, + new PrimaryReplicaEventParameters( + 85, // causalityToken, + new TablePartitionId(tableId, 0), // replicationGroupId + node.clusterService.topologyService().localMember().id(), // leaseholderId, + node.clusterService.topologyService().localMember().name(), // lease holder name + node.hybridClock.now() // lease start time + )); + + TableViewInternal tableViewInternal = node.tableManager.table(tableId); + KeyValueView<Tuple, Tuple> tableView = tableViewInternal.keyValueView(); + + node.transactions().runInTransaction(tx -> { + Tuple key = Tuple.create().set("KEY", 1L); + Tuple value = Tuple.create().set("VAL", 1).set("DOUBLEVAL", 1.0); + tableView.putAll(tx, Map.of(key, value)); Review Comment: Why is `putAll()` invoked to put just one tuple? ########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/handlers/BuildIndexCommandHandler.java: ########## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.table.distributed.raft.handlers; + +import static java.util.Objects.requireNonNull; +import static org.apache.ignite.internal.table.distributed.index.MetaIndexStatus.BUILDING; +import static org.apache.ignite.internal.table.distributed.index.MetaIndexStatus.REGISTERED; +import static org.apache.ignite.internal.util.CollectionUtils.last; + +import java.io.Serializable; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.List; +import java.util.UUID; +import java.util.stream.Stream; +import org.apache.ignite.internal.hlc.HybridTimestamp; +import org.apache.ignite.internal.lang.IgniteBiTuple; +import org.apache.ignite.internal.lang.IgniteInternalException; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.logger.Loggers; +import org.apache.ignite.internal.partition.replicator.network.command.BuildIndexCommand; +import org.apache.ignite.internal.partition.replicator.raft.handlers.AbstractCommandHandler; +import org.apache.ignite.internal.partition.replicator.raft.snapshot.PartitionDataStorage; +import org.apache.ignite.internal.schema.BinaryRow; +import org.apache.ignite.internal.schema.BinaryRowUpgrader; +import org.apache.ignite.internal.schema.SchemaDescriptor; +import org.apache.ignite.internal.schema.SchemaRegistry; +import org.apache.ignite.internal.storage.BinaryRowAndRowId; +import org.apache.ignite.internal.storage.MvPartitionStorage.Locker; +import org.apache.ignite.internal.storage.RowId; +import org.apache.ignite.internal.table.distributed.StorageUpdateHandler; +import org.apache.ignite.internal.table.distributed.index.IndexMeta; +import org.apache.ignite.internal.table.distributed.index.IndexMetaStorage; +import org.apache.ignite.internal.table.distributed.index.MetaIndexStatusChange; +import org.jetbrains.annotations.Nullable; + +/** + * Raft command handler that process {@link BuildIndexCommand}. Review Comment: ```suggestion * Raft command handler that handles {@link BuildIndexCommand}. ``` ########## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItBuildIndexTest.java: ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.partition.replicator; + +import static org.apache.ignite.internal.catalog.descriptors.CatalogIndexStatus.AVAILABLE; +import static org.apache.ignite.internal.placementdriver.event.PrimaryReplicaEvent.PRIMARY_REPLICA_ELECTED; +import static org.apache.ignite.internal.sql.SqlCommon.DEFAULT_SCHEMA_NAME; +import static org.apache.ignite.internal.testframework.IgniteTestUtils.waitForCondition; +import static org.apache.ignite.sql.ColumnType.DOUBLE; +import static org.apache.ignite.sql.ColumnType.INT32; +import static org.apache.ignite.sql.ColumnType.INT64; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.catalog.CatalogManager; +import org.apache.ignite.internal.catalog.commands.ColumnParams; +import org.apache.ignite.internal.catalog.descriptors.CatalogIndexDescriptor; +import org.apache.ignite.internal.hlc.HybridClock; +import org.apache.ignite.internal.index.message.IndexMessageGroup; +import org.apache.ignite.internal.index.message.IndexMessagesFactory; +import org.apache.ignite.internal.index.message.IsNodeFinishedRwTransactionsStartedBeforeRequest; +import org.apache.ignite.internal.partition.replicator.fixtures.Node; +import org.apache.ignite.internal.placementdriver.event.PrimaryReplicaEventParameters; +import org.apache.ignite.internal.replicator.TablePartitionId; +import org.apache.ignite.internal.table.TableTestUtils; +import org.apache.ignite.internal.table.TableViewInternal; +import org.apache.ignite.table.KeyValueView; +import org.apache.ignite.table.Tuple; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.Timeout; + +// TODO: https://issues.apache.org/jira/browse/IGNITE-22522 remove this test after the switching to zone-based replication +/** + * Tests catalog compaction for colocation track. + */ +@Timeout(60) +public class ItBuildIndexTest extends ItAbstractColocationTest { + private static final IndexMessagesFactory FACTORY = new IndexMessagesFactory(); + + @Test + public void testBuildIndex() throws Exception { + // Prepare a single node cluster. + startCluster(1); + Node node = getNode(0); + + placementDriver.setPrimary(node.clusterService.topologyService().localMember()); + + String zoneName = "test-zone"; + createZone(node, zoneName, 1, 1); + + String tableName = "TEST_TABLE"; + createCustomTable(node, zoneName, tableName); + int tableId = TableTestUtils.getTableId(node.catalogManager, tableName, node.hybridClock.nowLong()); + + // Test node does not create IndexNodeFinishedRwTransactionsChecker, so the following code is needed to unblock index building. + // It's easier than creating a real service with all its dependencies. + node.clusterService.messagingService().addMessageHandler( + IndexMessageGroup.class, + (message, sender, correlationId) -> { + if (message instanceof IsNodeFinishedRwTransactionsStartedBeforeRequest) { + node.clusterService.messagingService().respond( + sender, + FACTORY.isNodeFinishedRwTransactionsStartedBeforeResponse().finished(true).build(), + correlationId + ); + } + }); + + // Firing this event is a workaround to trigger the index building process. + // I agree that this approach is far from a good one and looks like a hack, + // but it's the only way to unblock the index building process using our test node. + placementDriver.fireTestEvent( + PRIMARY_REPLICA_ELECTED, + new PrimaryReplicaEventParameters( + 85, // causalityToken, + new TablePartitionId(tableId, 0), // replicationGroupId + node.clusterService.topologyService().localMember().id(), // leaseholderId, + node.clusterService.topologyService().localMember().name(), // lease holder name + node.hybridClock.now() // lease start time + )); + + TableViewInternal tableViewInternal = node.tableManager.table(tableId); + KeyValueView<Tuple, Tuple> tableView = tableViewInternal.keyValueView(); + + node.transactions().runInTransaction(tx -> { + Tuple key = Tuple.create().set("KEY", 1L); + Tuple value = Tuple.create().set("VAL", 1).set("DOUBLEVAL", 1.0); + tableView.putAll(tx, Map.of(key, value)); + }); + + // This async transaction is needed to update safe time, just because the idle safe time propagation is not implemented yet. + // https://issues.apache.org/jira/browse/IGNITE-22620 + CompletableFuture.runAsync(() -> { + try { + Thread.sleep(1_000); + node.transactions().runInTransaction(tx -> { + Tuple key = Tuple.create().set("KEY", 1L); + Tuple value = Tuple.create().set("VAL", 1).set("DOUBLEVAL", 1.0); + tableView.putAll(tx, Map.of(key, value)); Review Comment: Why is second put needed for the same key? ########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/handlers/BuildIndexCommandHandler.java: ########## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.table.distributed.raft.handlers; + +import static java.util.Objects.requireNonNull; +import static org.apache.ignite.internal.table.distributed.index.MetaIndexStatus.BUILDING; +import static org.apache.ignite.internal.table.distributed.index.MetaIndexStatus.REGISTERED; +import static org.apache.ignite.internal.util.CollectionUtils.last; + +import java.io.Serializable; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.List; +import java.util.UUID; +import java.util.stream.Stream; +import org.apache.ignite.internal.hlc.HybridTimestamp; +import org.apache.ignite.internal.lang.IgniteBiTuple; +import org.apache.ignite.internal.lang.IgniteInternalException; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.logger.Loggers; +import org.apache.ignite.internal.partition.replicator.network.command.BuildIndexCommand; +import org.apache.ignite.internal.partition.replicator.raft.handlers.AbstractCommandHandler; +import org.apache.ignite.internal.partition.replicator.raft.snapshot.PartitionDataStorage; +import org.apache.ignite.internal.schema.BinaryRow; +import org.apache.ignite.internal.schema.BinaryRowUpgrader; +import org.apache.ignite.internal.schema.SchemaDescriptor; +import org.apache.ignite.internal.schema.SchemaRegistry; +import org.apache.ignite.internal.storage.BinaryRowAndRowId; +import org.apache.ignite.internal.storage.MvPartitionStorage.Locker; +import org.apache.ignite.internal.storage.RowId; +import org.apache.ignite.internal.table.distributed.StorageUpdateHandler; +import org.apache.ignite.internal.table.distributed.index.IndexMeta; +import org.apache.ignite.internal.table.distributed.index.IndexMetaStorage; +import org.apache.ignite.internal.table.distributed.index.MetaIndexStatusChange; +import org.jetbrains.annotations.Nullable; + +/** + * Raft command handler that process {@link BuildIndexCommand}. + */ +public class BuildIndexCommandHandler extends AbstractCommandHandler<BuildIndexCommand> { + private static final IgniteLogger LOG = Loggers.forClass(BuildIndexCommandHandler.class); + + /** Data storage to which the command will be applied. */ + private final PartitionDataStorage storage; + + private final IndexMetaStorage indexMetaStorage; + + /** Handler that processes storage updates. */ + private final StorageUpdateHandler storageUpdateHandler; + + private final SchemaRegistry schemaRegistry; + + /** + * Creates a new instance of the command handler. + * + * @param storage Partition data storage. + * @param indexMetaStorage Index meta storage. + * @param storageUpdateHandler Storage update handler. + * @param schemaRegistry Schema registry. + */ + public BuildIndexCommandHandler( + PartitionDataStorage storage, + IndexMetaStorage indexMetaStorage, + StorageUpdateHandler storageUpdateHandler, + SchemaRegistry schemaRegistry + ) { + this.storage = storage; + this.indexMetaStorage = indexMetaStorage; + this.storageUpdateHandler = storageUpdateHandler; + this.schemaRegistry = schemaRegistry; + } + + @Override + protected IgniteBiTuple<Serializable, Boolean> handleInternally( + BuildIndexCommand command, + long commandIndex, + long commandTerm, + @Nullable HybridTimestamp safeTimestamp + ) throws IgniteInternalException { + // Skips the write command because the storage has already executed it. + if (commandIndex <= storage.lastAppliedIndex()) { + return new IgniteBiTuple<>(null, false); + } Review Comment: Would it make sense to move this logic to a template method calling `handleInternally()`? As it seems that every handler (or most of them) do this check. Not in this PR, of course. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
