sk0x50 commented on code in PR #5276:
URL: https://github.com/apache/ignite-3/pull/5276#discussion_r1973519722
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildController.java:
##########
@@ -131,35 +142,73 @@ public void close() {
}
private void addListeners() {
- catalogService.listen(CatalogEvent.INDEX_BUILDING,
(StartBuildingIndexEventParameters parameters) -> {
- return onIndexBuilding(parameters).thenApply(unused -> false);
- });
+ catalogService.listen(INDEX_BUILDING,
+ (StartBuildingIndexEventParameters parameters) ->
onIndexBuilding(parameters).thenApply(unused -> false));
- catalogService.listen(CatalogEvent.INDEX_REMOVED,
(RemoveIndexEventParameters parameters) -> {
- return onIndexRemoved(parameters).thenApply(unused -> false);
- });
+ catalogService.listen(INDEX_REMOVED,
+ (RemoveIndexEventParameters parameters) ->
onIndexRemoved(parameters).thenApply(unused -> false));
- placementDriver.listen(PrimaryReplicaEvent.PRIMARY_REPLICA_ELECTED,
parameters -> {
- return onPrimaryReplicaElected(parameters).thenApply(unused ->
false);
- });
+ placementDriver.listen(PRIMARY_REPLICA_ELECTED, parameters ->
onPrimaryReplicaElected(parameters).thenApply(unused -> false));
}
private CompletableFuture<?>
onIndexBuilding(StartBuildingIndexEventParameters parameters) {
return inBusyLockAsync(busyLock, () -> {
Catalog catalog =
catalogService.catalog(parameters.catalogVersion());
- assert catalog != null : "Not found catalog for version " +
parameters.catalogVersion();
+ assert catalog != null : "Failed to find a catalog for the
specified version [version=" + parameters.catalogVersion()
Review Comment:
IMHO, it would be an overhead and does not improve readability a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
