sashapolo commented on code in PR #5290:
URL: https://github.com/apache/ignite-3/pull/5290#discussion_r1971709920
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1605,19 +1604,15 @@ private CompletableFuture<Void>
tableStopFuture(TableImpl table) {
stopReplicaFutures[p] = stopPartition(replicationGroupId, table);
}
- CompletableFuture<Void> stopPartitionReplicasFuture =
allOf(stopReplicaFutures).orTimeout(10, TimeUnit.SECONDS);
-
- return stopPartitionReplicasFuture
- .whenCompleteAsync((res, ex) -> {
- Stream.Builder<ManuallyCloseable> stopping =
Stream.builder();
-
- stopping.add(internalTable.storage());
- stopping.add(internalTable.txStateStorage());
- stopping.add(internalTable);
-
+ return allOf(stopReplicaFutures)
Review Comment:
It shouldn't because we do `get(30, TimeUnit.SECONDS)` on the resulting
future outside
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
