tkalkirill commented on code in PR #5290:
URL: https://github.com/apache/ignite-3/pull/5290#discussion_r1971682799
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1605,19 +1604,15 @@ private CompletableFuture<Void>
tableStopFuture(TableImpl table) {
stopReplicaFutures[p] = stopPartition(replicationGroupId, table);
}
- CompletableFuture<Void> stopPartitionReplicasFuture =
allOf(stopReplicaFutures).orTimeout(10, TimeUnit.SECONDS);
-
- return stopPartitionReplicasFuture
- .whenCompleteAsync((res, ex) -> {
- Stream.Builder<ManuallyCloseable> stopping =
Stream.builder();
-
- stopping.add(internalTable.storage());
- stopping.add(internalTable.txStateStorage());
- stopping.add(internalTable);
-
+ return allOf(stopReplicaFutures)
Review Comment:
Can missing `.orTimeout(10, TimeUnit.SECONDS)` cause freezes?
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/impl/TestMvPartitionStorage.java:
##########
@@ -685,6 +685,10 @@ public long estimatedSize() {
@Override
public void close() {
+ if (rebalance) {
+ throw new StorageRebalanceException();
Review Comment:
Maybe it's worth specifying the partition and table here?
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/storage/state/rocksdb/TxStateRocksDbPartitionStorage.java:
##########
@@ -511,8 +525,10 @@ public CompletableFuture<Void>
finishRebalance(MvPartitionMeta partitionMeta) {
@Override
public CompletableFuture<Void> clear() {
- if (!state.compareAndSet(StorageState.RUNNABLE, StorageState.CLEANUP))
{
- throwExceptionDependingOnStorageState();
+ StorageState prevState =
state.compareAndExchange(StorageState.RUNNABLE, StorageState.CLEANUP);
Review Comment:
These stories look like candidates for a separate method, at your discretion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
