ivanzlenko commented on code in PR #5265:
URL: https://github.com/apache/ignite-3/pull/5265#discussion_r1967147252
##########
modules/runner/src/testFixtures/java/org/apache/ignite/internal/testframework/TestIgnitionManager.java:
##########
@@ -112,11 +112,36 @@ public class TestIgnitionManager {
* @throws IgniteException If error occurs while reading node
configuration.
*/
public static IgniteServer start(String nodeName, @Nullable String
configStr, Path workDir) {
+ return doStart(nodeName, configStr, workDir, true);
+ }
+
+ /**
+ * Starts an Ignite node with an optional bootstrap configuration from an
input stream with HOCON configs.
+ *
+ * <p>When this method returns, the node is partially started and ready to
accept the init command (that is, its
+ * REST endpoint is functional).
+ *
+ * @param nodeName Name of the node. Must not be {@code null}.
+ * @param configStr Optional node configuration.
+ * @param workDir Path to the working directory.
+ * @return Completable future that resolves into an Ignite node after all
components are started and the cluster initialization is
+ * complete.
+ * @throws IgniteException If error occurs while reading node
configuration.
+ */
+ public static IgniteServer startWithProductionDefaults(String nodeName,
@Nullable String configStr, Path workDir) {
+ return doStart(nodeName, configStr, workDir, false);
+ }
+
+ private static IgniteServer doStart(String nodeName, @Nullable String
configStr, Path workDir, boolean useTestDefaults) {
Review Comment:
Potentially we can swap useTestDefaults with enum. It will improve
readability by a mile and will make more futureproof if will want to include
more variety in our test configurations. However it is up to to change this,
since it is just nice to have, rather than mandatory thing.
##########
modules/runner/src/testFixtures/java/org/apache/ignite/internal/testframework/TestIgnitionManager.java:
##########
@@ -112,11 +112,36 @@ public class TestIgnitionManager {
* @throws IgniteException If error occurs while reading node
configuration.
*/
public static IgniteServer start(String nodeName, @Nullable String
configStr, Path workDir) {
+ return doStart(nodeName, configStr, workDir, true);
+ }
+
+ /**
+ * Starts an Ignite node with an optional bootstrap configuration from an
input stream with HOCON configs.
+ *
+ * <p>When this method returns, the node is partially started and ready to
accept the init command (that is, its
+ * REST endpoint is functional).
+ *
+ * @param nodeName Name of the node. Must not be {@code null}.
+ * @param configStr Optional node configuration.
+ * @param workDir Path to the working directory.
+ * @return Completable future that resolves into an Ignite node after all
components are started and the cluster initialization is
+ * complete.
+ * @throws IgniteException If error occurs while reading node
configuration.
+ */
Review Comment:
```suggestion
/**
* Starts an Ignite node with an optional bootstrap configuration
defined as a HOCON (Human-Optimized Config Object
* Notation) configuration string.
*
* <p>When this method returns, the node is partially started, meaning
its REST endpoint is functional and it is ready
* to accept the initialization command (e.g., for setting up the
cluster).
*
* @param nodeName The name of the node to start. Must not be {@code
null} and must be unique within the cluster.
* @param configStr An optional configuration string for the node
written in HOCON format. If {@code null}, the
* default configuration will be used.
* @param workDir The path to the working directory for the node. This
directory must exist and the application must
* have sufficient permissions to read from and write to
it.
* @return A {@link CompletableFuture} that resolves to the fully
initialized Ignite node with all components started and
* the cluster ready for further interactions.
* @throws IgniteException If an error occurs while reading or parsing
the node configuration.
* @throws IllegalArgumentException If {@code nodeName} is {@code null}
or invalid.
* @throws IOException If there are issues accessing or writing to the
specified {@code workDir}.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
