ivanzlenko commented on code in PR #5265:
URL: https://github.com/apache/ignite-3/pull/5265#discussion_r1967147252
##########
modules/runner/src/testFixtures/java/org/apache/ignite/internal/testframework/TestIgnitionManager.java:
##########
@@ -112,11 +112,36 @@ public class TestIgnitionManager {
* @throws IgniteException If error occurs while reading node
configuration.
*/
public static IgniteServer start(String nodeName, @Nullable String
configStr, Path workDir) {
+ return doStart(nodeName, configStr, workDir, true);
+ }
+
+ /**
+ * Starts an Ignite node with an optional bootstrap configuration from an
input stream with HOCON configs.
+ *
+ * <p>When this method returns, the node is partially started and ready to
accept the init command (that is, its
+ * REST endpoint is functional).
+ *
+ * @param nodeName Name of the node. Must not be {@code null}.
+ * @param configStr Optional node configuration.
+ * @param workDir Path to the working directory.
+ * @return Completable future that resolves into an Ignite node after all
components are started and the cluster initialization is
+ * complete.
+ * @throws IgniteException If error occurs while reading node
configuration.
+ */
+ public static IgniteServer startWithProductionDefaults(String nodeName,
@Nullable String configStr, Path workDir) {
+ return doStart(nodeName, configStr, workDir, false);
+ }
+
+ private static IgniteServer doStart(String nodeName, @Nullable String
configStr, Path workDir, boolean useTestDefaults) {
Review Comment:
Potentially we can swap useTestDefaults with enum. It will improve
readability by a mile and will make more futureproof if will want to include
more variety in our test configurations. However it is up to you to change
this, since it is just nice to have, rather than mandatory thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
