denis-chudov commented on code in PR #5092:
URL: https://github.com/apache/ignite-3/pull/5092#discussion_r1964364981
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DataNodesHistory.java:
##########
@@ -136,10 +134,10 @@ protected void writeExternalData(DataNodesHistory object,
IgniteDataOutput out)
@Override
protected DataNodesHistory readExternalData(byte protoVer,
IgniteDataInput in) throws IOException {
NavigableMap<HybridTimestamp, Set<NodeWithAttributes>> history =
in.readMap(
- new TreeMap<>(),
+ unused -> new TreeMap<>(),
in0 -> HybridTimestamp.hybridTimestamp(in0.readLong()),
in0 -> in0.readCollection(
- new HashSet<>(),
+ HashSet::new,
Review Comment:
I changed that part, pls recheck. In two words, we need ordered collection
here because it's serialized representations are compared as byte arrays
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
