denis-chudov commented on code in PR #5092: URL: https://github.com/apache/ignite-3/pull/5092#discussion_r1964363130
########## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DataNodesHistoryMetaStorageOperation.java: ########## @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.distributionzones; + +import static org.apache.ignite.internal.distributionzones.DistributionZonesUtil.nodeNames; +import static org.apache.ignite.internal.metastorage.dsl.Operations.ops; +import static org.apache.ignite.internal.metastorage.dsl.Statements.iif; + +import java.util.Set; +import org.apache.ignite.internal.hlc.HybridTimestamp; +import org.apache.ignite.internal.metastorage.dsl.Condition; +import org.apache.ignite.internal.metastorage.dsl.Iif; +import org.apache.ignite.internal.metastorage.dsl.Operations; +import org.jetbrains.annotations.Nullable; + +class DataNodesHistoryMetaStorageOperation { + private final Condition condition; + private final Operations msOperations; + private final String operationName; + private final int zoneId; + private final DataNodesHistory currentDataNodesHistory; + private final HybridTimestamp currentTimestamp; + private final HybridTimestamp historyEntryTimestamp; + private final Set<NodeWithAttributes> historyEntryNodes; + private final boolean addMandatoryEntry; + + @Nullable + private final DistributionZoneTimer scaleUpTimer; + + @Nullable + private final DistributionZoneTimer scaleDownTimer; + + private DataNodesHistoryMetaStorageOperation( + Condition condition, + Operations msOperations, + String operationName, + int zoneId, + DataNodesHistory currentDataNodesHistory, + HybridTimestamp currentTimestamp, + HybridTimestamp historyEntryTimestamp, + Set<NodeWithAttributes> historyEntryNodes, + boolean addMandatoryEntry, + @Nullable DistributionZoneTimer scaleUpTimer, + @Nullable DistributionZoneTimer scaleDownTimer + ) { + this.condition = condition; + this.msOperations = msOperations; + this.operationName = operationName; + this.zoneId = zoneId; + this.currentDataNodesHistory = currentDataNodesHistory; + this.currentTimestamp = currentTimestamp; + this.historyEntryTimestamp = historyEntryTimestamp; + this.historyEntryNodes = historyEntryNodes; + this.addMandatoryEntry = addMandatoryEntry; + this.scaleUpTimer = scaleUpTimer; + this.scaleDownTimer = scaleDownTimer; + } + + static Builder builder() { + return new Builder(); + } + + /** + * Forms a message for the log record about the history entry update. It also specifies whether the new history entry was + actually added; it is added if the history is empty, the nodes are different from the latest history entry or the + * {@code addMandatoryEntry} parameter is true. + * + * @return Log message. + */ + String logMessageOnSuccess() { + Set<NodeWithAttributes> latestNodesWritten = currentDataNodesHistory.dataNodesForTimestamp(HybridTimestamp.MAX_VALUE).dataNodes(); + Set<NodeWithAttributes> nodes = historyEntryNodes; + boolean historyEntryAdded = addMandatoryEntry || currentDataNodesHistory.isEmpty() || !nodes.equals(latestNodesWritten); + + return "Updated data nodes on " + operationName + ", " + + (historyEntryAdded ? "added history entry" : "history entry not added") + + " [zoneId=" + zoneId + ", currentTimestamp=" + currentTimestamp + + (historyEntryAdded ? ", historyEntryTimestamp=" + historyEntryTimestamp + ", nodes=" + nodeNames(nodes) : "") + + (historyEntryAdded ? "" : ", latestNodesWritten=" + nodeNames(latestNodesWritten)) + + "]" + + (scaleUpTimer == null ? "" : ", scaleUpTimer=" + scaleUpTimer) + + (scaleDownTimer == null ? "" : ", scaleDownTimer=" + scaleDownTimer) + + "]."; + } + + String logMessageOnFailure() { + return "Failed to update data nodes history and timers on " + operationName + " [timestamp=" + + currentTimestamp + "]."; + } + + Iif metaStorageIif() { Review Comment: here `Iif` allows to return it from method as a single object -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
