JAkutenshi commented on code in PR #5245: URL: https://github.com/apache/ignite-3/pull/5245#discussion_r1963512957
########## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/handlers/VacuumTxStatesCommandHandler.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.partition.replicator.raft.handlers; + +import java.io.Serializable; +import org.apache.ignite.internal.lang.IgniteBiTuple; +import org.apache.ignite.internal.tx.message.VacuumTxStatesCommand; +import org.apache.ignite.internal.tx.storage.state.TxStatePartitionStorage; + +/** + * RAFT command handler that process {@link VacuumTxStatesCommand} commands. + */ +public class VacuumTxStatesCommandHandler { + /** Storage of transaction metadata. */ + private final TxStatePartitionStorage txStatePartitionStorage; + + /** + * Creates a new instance of the command handler. + * + * @param txStatePartitionStorage Transactions state storage. + */ + public VacuumTxStatesCommandHandler(TxStatePartitionStorage txStatePartitionStorage) { + this.txStatePartitionStorage = txStatePartitionStorage; + } + + /** + * Handles {@link VacuumTxStatesCommand} command. + * + * @param command Command to be processed. + * @param commandIndex Command index. + * @param commandTerm Command term. + * @return Tuple with the result of the command processing and a flag indicating whether the command was applied. + */ + public IgniteBiTuple<Serializable, Boolean> handle(VacuumTxStatesCommand command, long commandIndex, long commandTerm) { + // Skips the write command because the storage has already executed it. Review Comment: I thought that `write` was excessive, but now with another ticket I see that was wrong, sorry. The command still counts as write -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
