sk0x50 commented on code in PR #5245: URL: https://github.com/apache/ignite-3/pull/5245#discussion_r1963473543
########## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/AbstractColocationTest.java: ########## @@ -68,107 +68,115 @@ import org.apache.ignite.network.NetworkAddress; import org.jetbrains.annotations.Nullable; import org.junit.jupiter.api.AfterEach; -import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.TestInfo; import org.junit.jupiter.api.extension.ExtendWith; +// TODO: https://issues.apache.org/jira/browse/IGNITE-22522 remove this test after the switching to zone-based replication + +/** + * Base class for tests that require a cluster with zone replication. + */ @ExtendWith(ConfigurationExtension.class) -@ExtendWith(ExecutorServiceExtension.class) @ExtendWith(SystemPropertiesExtension.class) -// TODO: https://issues.apache.org/jira/browse/IGNITE-22522 remove this test after the switching to zone-based replication +@ExtendWith(ExecutorServiceExtension.class) @WithSystemProperty(key = COLOCATION_FEATURE_FLAG, value = "true") -abstract class ItAbstractColocationTest extends IgniteAbstractTest { +public class AbstractColocationTest extends IgniteAbstractTest { Review Comment: The prefix you mentioned is a must for `final` test classes. Base/common classes do not need such a prefix like `IgniteAbstractTest`. Am I missing something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
