sanpwc commented on code in PR #5230:
URL: https://github.com/apache/ignite-3/pull/5230#discussion_r1959782737
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -2002,10 +1999,12 @@ private static CompletableFuture<List<BinaryRow>>
collectMultiRowsResponsesWithR
protected CompletableFuture<IgniteBiTuple<ClusterNode, Long>> enlist(int
partId, InternalTransaction tx) {
HybridTimestamp now = tx.startTimestamp();
- TablePartitionId tablePartitionId = new TablePartitionId(tableId,
partId);
- tx.assignCommitPartition(tablePartitionId);
+ ReplicationGroupId replicationGroupId =
targetReplicationGroupId(partId);
+
+ // TODO sanpwc ?
Review Comment:
Removed. I've considered an option to change commitPartitionId type to
ZonePartitionId - but gave up this idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
