rpuch commented on code in PR #5230:
URL: https://github.com/apache/ignite-3/pull/5230#discussion_r1959771372
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -2002,10 +1999,12 @@ private static CompletableFuture<List<BinaryRow>>
collectMultiRowsResponsesWithR
protected CompletableFuture<IgniteBiTuple<ClusterNode, Long>> enlist(int
partId, InternalTransaction tx) {
HybridTimestamp now = tx.startTimestamp();
- TablePartitionId tablePartitionId = new TablePartitionId(tableId,
partId);
- tx.assignCommitPartition(tablePartitionId);
+ ReplicationGroupId replicationGroupId =
targetReplicationGroupId(partId);
+
+ // TODO sanpwc ?
Review Comment:
A TODO without an issue reference
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxMessageSender.java:
##########
@@ -66,6 +68,9 @@ public class TxMessageSender {
private final TransactionConfiguration transactionConfiguration;
+ // TODO https://issues.apache.org/jira/browse/IGNITE-22522 Remove it.
+ private final boolean enabledColocationFeature =
getBoolean(COLOCATION_FEATURE_FLAG, false);
Review Comment:
We write this spell in many places. I suggest to introduce a static boolean
field `ENABLED_COLOCATION_DEFAULT` with value `false` to make it easier to
switch it globally and use it in all instances of this spell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
