sashapolo commented on code in PR #5232:
URL: https://github.com/apache/ignite-3/pull/5232#discussion_r1956412269
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -354,7 +326,6 @@ public PartitionReplicaLifecycleManager(
this.placementDriver = placementDriver;
this.txManager = txManager;
Review Comment:
> You can get it via zoneResourcesManager
I don't like this approach, because it looks weird that
`zoneResourcesManager` is responsible for having a `txManager` in it.
> Also, the possible option is to remove this field from zoneResourceManager
I don't like this approach, because we require passing an extra parameter,
which is a constant and is known during creation.
What's wrong with having this field in both places? Why do you think it's
bad?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
