sk0x50 commented on code in PR #5232:
URL: https://github.com/apache/ignite-3/pull/5232#discussion_r1956391144
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -354,7 +326,6 @@ public PartitionReplicaLifecycleManager(
this.placementDriver = placementDriver;
this.txManager = txManager;
Review Comment:
It looks like, this field is not needed anymore. You can get it via
`zoneResourcesManager`. WDYT?
Also, the possible option is to remove this field from `zoneResourceManager`
and, so `allocateZonePartitionResources` will use one more parameter as follows:
```
ZonePartitionResources zoneResources =
zoneResourcesManager.allocateZonePartitionResources(txManager, zonePartitionId,
partitionCount);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
