sanpwc commented on code in PR #5187: URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1946838105
########## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java: ########## @@ -124,6 +159,24 @@ private void processWriteCommand(CommandClosure<WriteCommand> clo) { clo.result(null); } + + // result == null means that the command either was not handled by anyone (and clo.result() is called) or + // that it was delegated to a table processor (which called clo.result()). + + if (result != null) { + if (Boolean.TRUE.equals(result.get2())) { + // Adjust safe time before completing update to reduce waiting. + if (safeTimestamp != null) { + updateTrackerIgnoringTrackerClosedException(safeTimeTracker, safeTimestamp); + } + + updateTrackerIgnoringTrackerClosedException(storageIndexTracker, clo.index()); + } + + // Completing the closure out of the partition snapshots lock to reduce possibility of deadlocks as it might Review Comment: Hope that we will have partition snapshots lock here soon)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org