sashapolo commented on PR #4990: URL: https://github.com/apache/ignite-3/pull/4990#issuecomment-2571744780
@12rcu but `waitForCondition` and JUnit's `@Timeout` annotation have different semantics. `waitForCondition` executes a predicate multiple times until either the condition is satisfied or the timeout is reached. `@Timeout` fails the test if it got "stuck" for more than the configured period of time. So, my question still stands: what does `@Timeout` achieve here, how does it even affect the flakiness of the test? > So in conclusion, the test is still flaky, but with my "fix" when the timeout is reached it will say so in the test reports But the name of your PR clearly states that your code is intended to fix the flakiness of the test, is the description incorrect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
