12rcu opened a new pull request, #4990: URL: https://github.com/apache/ignite-3/pull/4990
[https://issues.apache.org/jira/browse/IGNITE-21792](https://issues.apache.org/jira/browse/IGNITE-21792) Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ### The Review Checklist - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following: \- There is a single JIRA ticket related to the pull request. \- The web-link to the pull request is attached to the JIRA ticket. \- The JIRA ticket has the Patch Available state. \- The description of the JIRA ticket explains WHAT was made, WHY and HOW. \- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue. - [ ] **Design:** new code conforms with the design principles of the components it is added to. - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable. - [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed. - [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources. ### Notes - [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide) ### Issue Notes: Since the Jira ticket was not created by me, here is the summary of what was done: - Flakiness of the original test could only be reproduced by lowering the timeout of the assertions, even on bad hardware. - Fix: Remove the timeout in the assert statements and use a Junit `@Timeout` annotation with the summed time of the individual assert statements. - Flakiness from using this annotation could only be displayed with a massive reduction of the timeout value, see this action log: [https://github.com/12rcu/ignite-3/actions/runs/12575502390](https://github.com/12rcu/ignite-3/actions/runs/12575502390) (This uses an `@timeout` of 10 seconds, the final timeout is 25 seconds.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
