Vladsz83 commented on code in PR #11596:
URL: https://github.com/apache/ignite/pull/11596#discussion_r1898909488


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckProcess.java:
##########
@@ -474,70 +692,100 @@ private <T> GridFutureAdapter<T> phaseFuture() {
         }
     }
 
-    /** A DTO used to transfer nodes' results for the both phases. */
-    private static final class SnapshotCheckResponse implements Serializable {
-        /** Serial version uid. */
-        private static final long serialVersionUID = 0L;
-
-        /** @see #metas() */
-        @Nullable private final List<SnapshotMetadata> metas;
+    /** A DTO base to transfer node's results for the both phases. */
+    private abstract static class AbstractSnapshotCheckResponse<T> implements 
Serializable {

Review Comment:
   To avoid plenty of large generics in code like 
`CompletableFuture<SnapshotCheckResponse<Map<String, Map<PartitionKeyV2, 
PartitionHashRecordV2>>>>`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to