timoninmaxim commented on code in PR #11596:
URL: https://github.com/apache/ignite/pull/11596#discussion_r1898905476
##########
modules/core/src/main/java/org/apache/ignite/internal/management/cache/VerifyBackupPartitionsTaskV2.java:
##########
@@ -140,27 +157,6 @@ public class VerifyBackupPartitionsTaskV2 extends
ComputeTaskAdapter<CacheIdleVe
}
}
- /**
- * @param results Received results of broadcast remote requests.
- * @return Idle verify job result constructed from results of remote
executions.
- */
- public static IdleVerifyResultV2 reduce0(List<ComputeJobResult> results) {
Review Comment:
Why do you remove this method?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotChecker.java:
##########
@@ -634,23 +634,16 @@ else if (!res.exceptions().isEmpty())
/** */
public static IdleVerifyResultV2 reduceHashesResults(
- Map<ClusterNode, Map<PartitionKeyV2, PartitionHashRecordV2>> results,
+ Map<ClusterNode, Map<PartitionKeyV2, List<PartitionHashRecordV2>>>
results,
Map<ClusterNode, Exception> ex
) {
- Map<PartitionKeyV2, List<PartitionHashRecordV2>> clusterHashes = new
HashMap<>();
-
- results.forEach((node, nodeHashes) -> {
- assert ex.get(node) == null;
+ Map<PartitionKeyV2, List<PartitionHashRecordV2>> hashesRes = new
HashMap<>();
Review Comment:
Doesn't fixed
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckProcess.java:
##########
@@ -474,70 +692,100 @@ private <T> GridFutureAdapter<T> phaseFuture() {
}
}
- /** A DTO used to transfer nodes' results for the both phases. */
- private static final class SnapshotCheckResponse implements Serializable {
- /** Serial version uid. */
- private static final long serialVersionUID = 0L;
-
- /** @see #metas() */
- @Nullable private final List<SnapshotMetadata> metas;
+ /** A DTO base to transfer node's results for the both phases. */
+ private abstract static class AbstractSnapshotCheckResponse<T> implements
Serializable {
Review Comment:
Why this class abstract, when all inheritors just use constructor. Why do
you need all this classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
