xtern commented on code in PR #4907:
URL: https://github.com/apache/ignite-3/pull/4907#discussion_r1888843980
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/CursorInitializationPhaseHandler.java:
##########
@@ -54,11 +55,9 @@ public Result handle(Query query) {
query.cursor = cursor;
- query.cancel.add(timeout -> {
- if (!timeout) {
- cursor.closeAsync(true);
- }
- });
+ query.cancel.add(timeout -> dataCursor.cancelAsync(
+ timeout ? CancellationReason.TIMEOUT :
CancellationReason.CANCEL
Review Comment:
I reread the ticket description and I want to clarify that if it is
difficult to write a reproducer, then you can ignore this note.
At first I thought we didn't have a timeout test that triggers an implicit
RW transaction. We do have those, right?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
