xtern commented on code in PR #4907:
URL: https://github.com/apache/ignite-3/pull/4907#discussion_r1888805074
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/CursorInitializationPhaseHandler.java:
##########
@@ -54,11 +55,9 @@ public Result handle(Query query) {
query.cursor = cursor;
- query.cancel.add(timeout -> {
Review Comment:
1. can we also remove the code that adds timeout handling in `executeDdl`
and `executeKill` methods of `ExecutionServiceImpl`?
2. сan we add a test that will reproduce the issue the patch solves?
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/CursorInitializationPhaseHandler.java:
##########
@@ -54,11 +55,9 @@ public Result handle(Query query) {
query.cursor = cursor;
- query.cancel.add(timeout -> {
- if (!timeout) {
- cursor.closeAsync(true);
- }
- });
+ query.cancel.add(timeout -> dataCursor.cancelAsync(
+ timeout ? CancellationReason.TIMEOUT :
CancellationReason.CANCEL
Review Comment:
1. can we also remove the code that adds timeout handling in `executeDdl`
and `executeKill` methods of `ExecutionServiceImpl`?
2. сan we add a test that will reproduce the issue the patch solves?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
