nva commented on code in PR #4832:
URL: https://github.com/apache/ignite-3/pull/4832#discussion_r1877860501
##########
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricManagerImpl.java:
##########
@@ -259,7 +259,7 @@ public CompletableFuture<?>
onDelete(ConfigurationNotificationEvent<ExporterView
public CompletableFuture<?>
onUpdate(ConfigurationNotificationEvent<ExporterView> ctx) {
MetricExporter exporter =
enabledMetricExporters.get(ctx.newValue().exporterName());
- if (exporter != null) {
+ if (exporter != null && ctx.oldValue() != null) {
Review Comment:
Nice catch!
This check is not really necessary as it done before calling `onUpdate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
