nva commented on code in PR #4832:
URL: https://github.com/apache/ignite-3/pull/4832#discussion_r1877239249
##########
modules/metrics/src/integrationTest/java/org/apache/ignite/internal/metrics/exporters/TestPushMetricExporter.java:
##########
@@ -36,23 +33,13 @@ public class TestPushMetricExporter extends
PushMetricExporter<TestPushMetricsEx
private static OutputStream outputStream;
- private long period;
-
- @Override
- public void start(MetricProvider metricsProvider,
TestPushMetricsExporterView configuration, Supplier<UUID> clusterIdSupplier,
- String nodeName) {
- period = configuration.period();
-
- super.start(metricsProvider, configuration, clusterIdSupplier,
nodeName);
- }
-
public static void setOutputStream(OutputStream outputStream) {
TestPushMetricExporter.outputStream = outputStream;
}
@Override
protected long period() {
- return period;
+ return configuration().period();
Review Comment:
Because configuration in ancestor PushMetricExporter has type ExporterView
which is common for push and pull exporters and doesn't contain period. At the
same time configuration framework doesn't allow to create base class for
PushExporterConfiguration as ExporterView is a polymorphic configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
