xtern commented on PR #4799: URL: https://github.com/apache/ignite-3/pull/4799#issuecomment-2522507882
> proposed code organization looks quite strange, tbh: we have registry which requires topology service for some reason; kill command is processed by execution service, but distributed coordination os done by registry > > I would like to propose to organize it similar to DDL processing: > > * introduce package `org.apache.ignite.internal.sql.engine.exec.kill` > > * move to this package `KillCommand` and `KillHandlerRegistryImpl` > > * rename `KillHandlerRegistryImpl` to `KillComamndHandler` > > * it still implements `KillHandlerRegistry` > * all processing is done within `KillComamndHandler`, execution service only passes the command Done. But from my point of view it would be better to keep `HandlerRegistryImpl` where it was implemented and add a separate KillCommandHandler that will use the registry :sunglasses: Otherwise, the area of ​​responsibility of KIllCommandHandler is not very clear now (why is it responsible for registering handlers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
