korlov42 commented on code in PR #4799:
URL: https://github.com/apache/ignite-3/pull/4799#discussion_r1870849793
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/AsyncResultSetImpl.java:
##########
@@ -72,7 +72,9 @@ public AsyncResultSetImpl(
/** {@inheritDoc} */
@Override
public boolean hasRowSet() {
- return cursor.queryType() == SqlQueryType.QUERY || cursor.queryType()
== SqlQueryType.EXPLAIN;
+ return cursor.queryType() == SqlQueryType.QUERY
+ || cursor.queryType() == SqlQueryType.EXPLAIN
+ || cursor.queryType() == SqlQueryType.KILL;
Review Comment:
I think, the KILL statement should be similar to DDL rather than QUERY.
Please check `AsyncResultSet#wasApplied`
##########
modules/sql-engine-api/src/main/java/org/apache/ignite/internal/sql/engine/api/kill/OperationKillHandler.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine.api.kill;
+
+import java.util.concurrent.CompletableFuture;
+
+/**
+ * Handler that can abort operations of a certain type.
+ *
+ * @see KillHandlerRegistry#register(OperationKillHandler)
+ */
+public interface OperationKillHandler {
+ /**
+ * Cancels an operation with the specified ID.
+ *
+ * @param operationId ID of the operation to cancel.
+ * @return {@code true} if the operation was successfully canceled,
+ * {@code false} if a specific operation was not found or is
inactive.
Review Comment:
> or is inactive.
this sound misleading. I assume you've got this condition from compute, but
in general what is wrong with inactive operations? Why it's not possible to
cancel them?
##########
modules/sql-engine-api/src/main/java/org/apache/ignite/internal/sql/engine/api/kill/OperationKillHandler.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine.api.kill;
+
+import java.util.concurrent.CompletableFuture;
+
+/**
+ * Handler that can abort operations of a certain type.
+ *
+ * @see KillHandlerRegistry#register(OperationKillHandler)
+ */
+public interface OperationKillHandler {
+ /**
+ * Cancels an operation with the specified ID.
+ *
+ * @param operationId ID of the operation to cancel.
+ * @return {@code true} if the operation was successfully canceled,
+ * {@code false} if a specific operation was not found or is
inactive.
+ */
+ CompletableFuture<Boolean> cancelAsync(String operationId);
+
+ /**
+ * Returns whether the handler can abort operations only on local node or
across the entire cluster.
+ *
+ * @return {@code True} if the handler can abort operations only on local
node,
Review Comment:
let's add to javadoc, that for local-only handlers distributed coordination
will be done by sql engine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
