korlov42 commented on code in PR #4814:
URL: https://github.com/apache/ignite-3/pull/4814#discussion_r1869606158


##########
modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/JdbcConnection.java:
##########
@@ -78,6 +79,8 @@ public class JdbcConnection implements Connection {
     /** Statements modification mutex. */
     private final Object stmtsMux = new Object();
 
+    private final AtomicLong tokenGenerator = new AtomicLong(Long.MIN_VALUE);

Review Comment:
   this, actually, artifact of debugging... Correlation token is of primitive 
type in all the request objects, therefore when you forget to amend 
serialization, request won't fail, but will have incorrect attributes instead. 
Setting initial value different from zero helped me to find all such missed 
places.
   
   Anyway, removed initialization with custom value to avoid confusion (btw, 
AtomicLong do wrap around on boundaries, so we have here effectively infinite 
amount of tokens)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to