vldpyatkov commented on code in PR #4808:
URL: https://github.com/apache/ignite-3/pull/4808#discussion_r1863067607
##########
modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java:
##########
@@ -111,20 +111,30 @@ public final HybridTimestamp current() {
*/
@Override
public final HybridTimestamp update(HybridTimestamp requestTime) {
- while (true) {
- long now = currentTime();
+ long requestTimeLong = requestTime.longValue();
+ while (true) {
// Read the latest time after accessing UTC time to reduce
contention.
- long oldLatestTime = latestTime;
+ long oldLatestTime = this.latestTime;
- long newLatestTime = max(requestTime.longValue() + 1, max(now,
oldLatestTime + 1));
+ if (oldLatestTime >= requestTimeLong) {
+ return hybridTimestamp(LATEST_TIME.incrementAndGet(this));
+ }
Review Comment:
It seems it is the obvious requirement. The clock current time has to be
bigger than the value in parameters. The minimum change is incrementing the old
value in the clock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
