rpuch commented on code in PR #4808:
URL: https://github.com/apache/ignite-3/pull/4808#discussion_r1863040737
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/HeapLockManager.java:
##########
@@ -174,7 +174,7 @@ public CompletableFuture<Lock> acquire(UUID txId, LockKey
lockKey, LockMode lock
if (lockKey.contextId() == null) { // Treat this lock as a
hierarchy(coarse) lock.
CoarseLockState state = coarseMap.computeIfAbsent(lockKey, key ->
new CoarseLockState(lockKey));
- return state.acquire(txId, lockKey, lockMode);
+ return state.acquire(txId, lockMode);
Review Comment:
Why is this change made? And why is it in this PR? It doesn't seem to relate
to the clock
##########
modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java:
##########
@@ -111,20 +111,30 @@ public final HybridTimestamp current() {
*/
@Override
public final HybridTimestamp update(HybridTimestamp requestTime) {
- while (true) {
- long now = currentTime();
+ long requestTimeLong = requestTime.longValue();
+ while (true) {
// Read the latest time after accessing UTC time to reduce
contention.
- long oldLatestTime = latestTime;
+ long oldLatestTime = this.latestTime;
- long newLatestTime = max(requestTime.longValue() + 1, max(now,
oldLatestTime + 1));
+ if (oldLatestTime >= requestTimeLong) {
+ return hybridTimestamp(LATEST_TIME.incrementAndGet(this));
+ }
- // TODO https://issues.apache.org/jira/browse/IGNITE-23707 avoid
CAS on logical part update.
+ long now = currentTime();
+
+ if (now > requestTimeLong) {
+ if (LATEST_TIME.compareAndSet(this, oldLatestTime, now)) {
+ return hybridTimestamp(now);
Review Comment:
Why don't we notify listeners in these cases? Clock is still moved forward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
