timoninmaxim commented on code in PR #11675:
URL: https://github.com/apache/ignite/pull/11675#discussion_r1856074557
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexScan.java:
##########
@@ -122,10 +117,9 @@ public IndexScan(
txChanges = ectx.transactionChanges(
cctx.cacheId(),
parts,
- r -> new IndexRowImpl(rowHnd, r)
+ r -> new IndexRowImpl(rowHnd, r),
+ this::compare
);
-
- txChanges.get2().sort(this::compare);
}
else
txChanges = null;
Review Comment:
Can replace with TransactionChanges#EMPTY, it will done automatically in
call `ectx.transactionChanges`. It will help to remove useless check for null
in 254L.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
