nizhikov commented on code in PR #11675:
URL: https://github.com/apache/ignite/pull/11675#discussion_r1855939036
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/tx/SqlTransactionsIsolationTest.java:
##########
@@ -218,32 +96,29 @@ public enum ModifyApi {
}
});
- /** */
- private final TransactionIsolation txIsolation = READ_COMMITTED;
-
/** */
private final Map<Integer, Set<Integer>> partsToKeys = new HashMap<>();
/** @return Test parameters. */
@Parameterized.Parameters(
- name =
"modify={0},qryExecutor={1},partitionAwareness={2},mode={3},gridCnt={4},backups={5},commit={6},multi={7},txConcurrency={8}")
+ name =
"gridCnt={0},backups={1},partitionAwareness={2},mode={3},execType={4},modify={5},commit={6},multi={7},txConcurrency={8}")
public static Collection<?> parameters() {
List<Object[]> params = new ArrayList<>();
- for (CacheMode cacheMode : CacheMode.values()) {
- for (int gridCnt : new int[]{1, 3}) {
- int[] backups = gridCnt > 1
- ? new int[]{1, gridCnt - 1}
- : new int[]{0};
- for (int backup: backups) {
+ for (int gridCnt : new int[]{1, 3}) {
+ int[] backups = gridCnt > 1
+ ? new int[]{1, gridCnt - 1}
+ : new int[]{0};
+ for (int backup : backups) {
+ for (CacheMode mode : CacheMode.values()) {
for (ModifyApi modify : ModifyApi.values()) {
for (boolean commit : new boolean[]{false, true}) {
- for (boolean mutli : new boolean[] {false, true}) {
+ for (boolean mutli : new boolean[]{false, true}) {
for (TransactionConcurrency txConcurrency :
TransactionConcurrency.values()) {
ExecutorType[] nodeExecTypes =
{ExecutorType.SERVER, ExecutorType.CLIENT};
ExecutorType[] thinExecTypes;
- if (modify == SQL) {
Review Comment:
The main reason to include test changes in patch is to reduce main patch.
Exclude obvious changes from it.
So I thins yes, we need this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
