rpuch commented on code in PR #4771:
URL: https://github.com/apache/ignite-3/pull/4771#discussion_r1853766804
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -2703,9 +2705,25 @@ private CompletableFuture<Void>
destroyPartitionStorages(TablePartitionId tableP
destroyFutures.add(runAsync(() ->
internalTable.txStateStorage().destroyTxStateStorage(partitionId), ioExecutor));
}
+ destroyFutures.add(
+ supplyAsync(() ->
destroyReplicationProtocolStorages(tablePartitionId, table),
ioExecutor).thenCompose(identity())
+ );
+
return allOf(destroyFutures.toArray(new CompletableFuture[]{}));
}
+ private CompletableFuture<Object>
destroyReplicationProtocolStorages(TablePartitionId tablePartitionId, TableImpl
table) {
Review Comment:
`CompletionException` looks nice when written explicitly in a closure
belonging to `runAsync()` (or another method of `CompletableFuture`), but I
extracted the method on purpose to hide that try/catch. When the method is
isolated, it's a bit weird to use a `CompletionException` in it, that's why I
preferred a neutral exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
