rpuch commented on code in PR #4771:
URL: https://github.com/apache/ignite-3/pull/4771#discussion_r1853643517
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -2703,9 +2705,25 @@ private CompletableFuture<Void>
destroyPartitionStorages(TablePartitionId tableP
destroyFutures.add(runAsync(() ->
internalTable.txStateStorage().destroyTxStateStorage(partitionId), ioExecutor));
}
+ destroyFutures.add(
+ supplyAsync(() ->
destroyReplicationProtocolStorages(tablePartitionId, table),
ioExecutor).thenCompose(identity())
+ );
+
return allOf(destroyFutures.toArray(new CompletableFuture[]{}));
}
+ private CompletableFuture<Object>
destroyReplicationProtocolStorages(TablePartitionId tablePartitionId, TableImpl
table) {
Review Comment:
I used the future to communicate an exception to the caller. This looks like
an abuse, so now I changed it to wrapping the checked exception in
`IgniteInternalException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
